Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: aesop_graph? macro #15124

Closed
wants to merge 1 commit into from
Closed

Conversation

0art0
Copy link
Collaborator

@0art0 0art0 commented Jul 25, 2024

aesop_graph? was invoking aesop, while it should have been invoking aesop?.


Open in Gitpod

`aesop_graph?` was invoking `aesop`, while it should have been invoking `aesop?`
Copy link

PR summary 5797dc3f26

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@grunweg grunweg changed the title aesop_graph? macro fix fix: aesop_graph? macro Jul 25, 2024
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 25, 2024
`aesop_graph?` was invoking `aesop`, while it should have been invoking `aesop?`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: aesop_graph? macro [Merged by Bors] - fix: aesop_graph? macro Jul 25, 2024
@mathlib-bors mathlib-bors bot closed this Jul 25, 2024
@mathlib-bors mathlib-bors bot deleted the 0art0aesop_graph branch July 25, 2024 12:25
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants