Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: make #where command commonly available again #15139

Closed
wants to merge 1 commit into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Jul 25, 2024


Open in Gitpod

@fpvandoorn
Copy link
Member

bors d+

Maybe other Battery-commands should be checked as well?

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 25, 2024

✌️ kmill can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link

PR summary 2ddff3d4a6

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.Common 233 234 +1 (+0.43%)
Import changes for all files
Files Import difference
There are 4016 files with changed transitive imports: this is too many to display!

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@kmill
Copy link
Contributor Author

kmill commented Jul 25, 2024

bors r+

(I agree with the idea to make sure other batteries commands are included, but I'll leave that for someone else! :-))

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 25, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: make #where command commonly available again [Merged by Bors] - chore: make #where command commonly available again Jul 25, 2024
@mathlib-bors mathlib-bors bot closed this Jul 25, 2024
@mathlib-bors mathlib-bors bot deleted the kmill_common_where branch July 25, 2024 22:15
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants