Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: move files into Analysis.Normed.Algebra #15146

Closed
wants to merge 2 commits into from

Conversation

j-loreaux
Copy link
Collaborator


This is meant to be one part of a larger organizational project for Analysis.NormedSpace. This moves files related to algebras into their own folder.

Open in Gitpod

Copy link

github-actions bot commented Jul 25, 2024

PR summary 2f79a6d164

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Analysis.NormedSpace.Algebra -1907
Mathlib.Analysis.NormedSpace.Spectrum -1905
Mathlib.Analysis.NormedSpace.TrivSqZeroExt -1441
Mathlib.Analysis.NormedSpace.UnitizationL1 -1378
Mathlib.Analysis.NormedSpace.Unitization -1272
Mathlib.Analysis.Normed.Algebra.Unitization 1272
Mathlib.Analysis.Normed.Algebra.UnitizationL1 1378
Mathlib.Analysis.Normed.Algebra.TrivSqZeroExt 1441
Mathlib.Analysis.Normed.Algebra.Spectrum 1905
Mathlib.Analysis.Normed.Algebra.Basic 1907

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@grunweg
Copy link
Collaborator

grunweg commented Jul 26, 2024

Grouping these files looks reasonable. The new folder "Algebra" is ambiguous (and could refer to the mathematical object as well to the area); I don't see an obvious alternative, though. Let's have some more eyes on this:
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 26, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: move files into Analysis.Normed.Algebra [Merged by Bors] - chore: move files into Analysis.Normed.Algebra Jul 26, 2024
@mathlib-bors mathlib-bors bot closed this Jul 26, 2024
@mathlib-bors mathlib-bors bot deleted the j-loreaux/move-normed-algebra-files branch July 26, 2024 09:13
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants