Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(RingTheory/Radical): Theorems for coprime elements + alpha #15331

Closed
wants to merge 29 commits into from
Closed

[Merged by Bors] - feat(RingTheory/Radical): Theorems for coprime elements + alpha #15331

wants to merge 29 commits into from

Conversation

seewoo5
Copy link
Collaborator

@seewoo5 seewoo5 commented Jul 30, 2024 •
edited
Loading

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 30, 2024
@seewoo5 seewoo5 added t-algebra Algebra (groups, rings, fields, etc) and removed new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! labels Jul 30, 2024
@seewoo5 seewoo5 self-assigned this Jul 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

PR summary 024a80ca52

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ disjoint_normalizedFactors
+ disjoint_primeFactors
+ mul_primeFactors_disjUnion
+ radical_mul
+ radical_ne_zero
+ radical_neg
+ radical_neg_one

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 30, 2024
@seewoo5
Copy link
Collaborator Author

seewoo5 commented Jul 30, 2024

@erdOne Thank you for the reviews! It seems that most of them are for #14873. Could you leave the comments there? Then I'll updated in that PR accordingly.

@seewoo5 seewoo5 mentioned this pull request Jul 30, 2024
Closed
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Aug 5, 2024
This was referenced Aug 5, 2024
Closed
Closed
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Sep 11, 2024
View reviewed changes
Mathlib/RingTheory/Radical.lean Outdated
-- Theorems for commutative rings

-- TODO: This holds for "nontrivial" monoids - do not need ring assumption.
theorem radical_ne_zero (a : R) : radical a ≠ 0 := by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please state it in the generality that works.

Mathlib/RingTheory/Radical.lean Outdated
rw [Finset.prod_disjUnion (disjoint_primeFactors hc)]

theorem radical_neg {a : R} : radical (-a) = radical a :=
neg_one_mul a ▸ (radical_eq_of_associated <| associated_unit_mul_left a (-1) isUnit_one.neg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I added a lemma that a and -a are associated at some point. Can you please look for it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at Algebra.Associated.Basic now, and I can find neg_left or neg_right which can be used combined with rfl, but not exactly something like Associated (-a) a. Should I look for different file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radical_eq_of_associated (.neg_right .rfl) (or some thing similar; not tested) is still shorter than this though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erdOne Just updated - radical_eq_of_associated Associated.rfl.neg_left worked!

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 11, 2024
@seewoo5 seewoo5 removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 7, 2024
@seewoo5
Copy link
Collaborator Author

seewoo5 commented Oct 14, 2024

@Ruben-VandeVelde Hi, let me know if there are anything that I may update, thanks!

erdOne
erdOne reviewed Oct 17, 2024
View reviewed changes
Mathlib/RingTheory/Radical.lean Outdated
rw [Finset.prod_disjUnion (disjoint_primeFactors hc)]

theorem radical_neg {a : R} : radical (-a) = radical a :=
neg_one_mul a ▸ (radical_eq_of_associated <| associated_unit_mul_left a (-1) isUnit_one.neg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radical_eq_of_associated (.neg_right .rfl) (or some thing similar; not tested) is still shorter than this though.

@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 17, 2024
@seewoo5 seewoo5 removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 19, 2024
jcommelin
jcommelin reviewed Oct 26, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 26, 2024

✌️ seewoo5 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@seewoo5
Copy link
Collaborator Author

seewoo5 commented Oct 26, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 26, 2024
@seewoo5
feat(RingTheory/Radical): Theorems for coprime elements + alpha (#15331)
8102abc 
Co-authored-by: Jineon Baek <[email protected]>
Co-authored-by: Seewoo Lee <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Radical): Theorems for coprime elements + alpha [Merged by Bors] - feat(RingTheory/Radical): Theorems for coprime elements + alpha Oct 26, 2024
@mathlib-bors mathlib-bors bot closed this Oct 26, 2024
@mathlib-bors mathlib-bors bot deleted the feature/element-radical-coprime branch October 26, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@erdOne erdOne erdOne left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

@seewoo5 seewoo5

Labels
delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seewoo5 @leanprover-community-mathlib4-bot @jcommelin @erdOne @Ruben-VandeVelde