Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: divRadical for polynomials #18452

Closed
wants to merge 15 commits into from

Conversation

seewoo5
Copy link
Collaborator

@seewoo5 seewoo5 commented Oct 30, 2024

@seewoo5 seewoo5 added the t-algebra Algebra (groups, rings, fields, etc) label Oct 30, 2024
@seewoo5 seewoo5 requested a review from YaelDillies October 30, 2024 17:55
@seewoo5 seewoo5 self-assigned this Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

PR summary a99e337c07

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.Polynomial.Radical 1130

Declarations diff

+ divRadical_dvd_derivative
+ divRadical_dvd_wronskian_left
+ divRadical_dvd_wronskian_right

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 30, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 31, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 31, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 31, 2024
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Nov 1, 2024
@seewoo5 seewoo5 removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 2, 2024
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

apart from that. Thanks!

@YaelDillies YaelDillies changed the title divRadical for polynomials feat: divRadical for polynomials Nov 2, 2024
Copy link

github-actions bot commented Nov 2, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Nov 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 4, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: divRadical for polynomials [Merged by Bors] - feat: divRadical for polynomials Nov 4, 2024
@mathlib-bors mathlib-bors bot closed this Nov 4, 2024
@mathlib-bors mathlib-bors bot deleted the feature/divradical-poly branch November 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants