Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Combinatorics/SimpleGraph): define Copy #20658

Closed
wants to merge 25 commits into from

Conversation

mitchell-horner
Copy link
Collaborator

@mitchell-horner mitchell-horner commented Jan 11, 2025

Define the type Copy as the subtype of injective homomorphisms.

Also define

  • the predicate that a simple graph contains another simple graph IsContained (equivalent to "is isomorphic to a subgraph of"),
  • the predicate that a simple graph is free of another simple graph Free for convenience.

Open in Gitpod

@mitchell-horner mitchell-horner added the t-combinatorics Combinatorics label Jan 11, 2025
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jan 11, 2025
Copy link

github-actions bot commented Jan 11, 2025

messageFile.md

@YaelDillies YaelDillies self-assigned this Jan 12, 2025
Copy link

github-actions bot commented Feb 6, 2025

messageFile.md

@YaelDillies
Copy link
Collaborator

Can you merge master? This will fix the bot

@kbuzzard kbuzzard added the awaiting-author A reviewer has asked the author a question or requested changes label Feb 24, 2025
@kbuzzard
Copy link
Member

@mitchell-horner can you merge master and resolve all comments which you have dealt with?

Copy link

github-actions bot commented Feb 24, 2025

PR summary ea7425d09e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Combinatorics.SimpleGraph.Copy (new file) 593

Declarations diff

+ Copy
+ Embedding.toCopy
+ Free
+ Hom.toCopy
+ IsContained
+ IsContained.bot
+ IsContained.exists_iso_subgraph
+ IsContained.mono_left
+ IsContained.mono_right
+ IsContained.of_exists_iso_subgraph
+ IsContained.of_isEmpty
+ IsContained.of_le
+ IsContained.refl
+ IsContained.rfl
+ IsContained.trans
+ IsContained.trans'
+ IsContained.trans_le
+ IsContained.trans_le'
+ Iso.toCopy
+ Subgraph.Copy.map
+ Subgraph.coeCopy
+ Subgraph.coe_isContained
+ bot
+ bot_isContained_iff_card_le
+ coe_comp
+ coe_id
+ coe_ofLE
+ coe_toHom
+ coe_toHom_apply
+ comp
+ comp_apply
+ free_bot
+ free_congr
+ id
+ induce
+ injective
+ instance : FunLike (Copy A B) α β
+ isContained_congr
+ isContained_iff_exists_iso_subgraph
+ mapEdgeSet
+ mapNeighborSet
+ not_free
+ ofLE
+ ofLE_comp
+ ofLE_refl
+ toEmbedding
+ toHom

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mitchell-horner
Copy link
Collaborator Author

@kbuzzard I've been waiting for others' input on the name SubgraphIso. Feel free to weigh in. 😁

@mitchell-horner mitchell-horner changed the title feat(Combinatorics/SimpleGraph): define SubgraphIso feat(Combinatorics/SimpleGraph): define Copy Mar 4, 2025
@mitchell-horner mitchell-horner removed the awaiting-author A reviewer has asked the author a question or requested changes label Mar 5, 2025
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 5, 2025
@YaelDillies
Copy link
Collaborator

I still think IsContained is a better name than IsIsoSubgraph. What do you think, @b-mehta ?

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 8, 2025
@mitchell-horner mitchell-horner removed the awaiting-author A reviewer has asked the author a question or requested changes label Mar 12, 2025
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@b-mehta
Copy link
Contributor

b-mehta commented Mar 14, 2025

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 14, 2025

✌️ mitchell-horner can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mitchell-horner
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 15, 2025
Define the type `Copy` as the subtype of injective homomorphisms.

Also define

- the predicate that a simple graph contains another simple graph `IsContained` (equivalent to "is isomorphic to a subgraph of"),
- the predicate that a simple graph is free of another simple graph `Free` for convenience.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Combinatorics/SimpleGraph): define Copy [Merged by Bors] - feat(Combinatorics/SimpleGraph): define Copy Mar 15, 2025
@mathlib-bors mathlib-bors bot closed this Mar 15, 2025
@mathlib-bors mathlib-bors bot deleted the mitchell-horner/subgraph-iso branch March 15, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-combinatorics Combinatorics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants