Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Order/Group/Abs): use @[to_additive] #22468

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 2, 2025


Open in Gitpod

Copy link

github-actions bot commented Mar 2, 2025

PR summary f94fd59ad5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ div_le_of_mabs_div_le_left
+ div_le_of_mabs_div_le_right
+ div_lt_of_mabs_div_lt_left
+ div_lt_of_mabs_div_lt_right
+ eq_of_mabs_div_eq_one
+ eq_of_mabs_div_le_all
+ eq_of_mabs_div_le_one
+ eq_of_mabs_div_lt_all
+ inv_le_of_mabs_le
+ le_mabs'
+ le_of_mabs_le
+ mabs_cases
+ mabs_div
+ mabs_div_le
+ mabs_div_le_iff
+ mabs_div_le_of_le_of_le
+ mabs_div_le_of_one_le_of_le
+ mabs_div_le_one
+ mabs_div_lt_iff
+ mabs_div_lt_of_one_le_of_lt
+ mabs_div_mabs_le_mabs_div
+ mabs_div_pos
+ mabs_eq
+ mabs_eq_inv_self
+ mabs_eq_self
+ mabs_le
+ mabs_le_max_mabs_mabs
+ mabs_mabs_div_mabs_le_mabs_div
+ mabs_max_le_max_mabs_mabs
+ mabs_min_le_max_mabs_mabs
+ mabs_mul
+ mabs_mul'
+ mabs_mul_three
+ max_one_mul_max_inv_one_eq_mabs_self
+ min_mabs_mabs_le_mabs_max
+ min_mabs_mabs_le_mabs_min
- abs_abs_sub_abs_le_abs_sub
- abs_add
- abs_add'
- abs_add_three
- abs_cases
- abs_eq
- abs_eq_neg_self
- abs_eq_self
- abs_le
- abs_le_max_abs_abs
- abs_max_le_max_abs_abs
- abs_min_le_max_abs_abs
- abs_sub
- abs_sub_abs_le_abs_sub
- abs_sub_le
- abs_sub_le_iff
- abs_sub_le_of_nonneg_of_le
- abs_sub_lt_iff
- abs_sub_lt_of_nonneg_of_lt
- abs_sub_nonpos
- abs_sub_pos
- eq_of_abs_sub_eq_zero
- eq_of_abs_sub_le_all
- eq_of_abs_sub_lt_all
- eq_of_abs_sub_nonpos
- le_abs'
- le_of_abs_le
- max_zero_add_max_neg_zero_eq_abs_self
- min_abs_abs_le_abs_max
- min_abs_abs_le_abs_min
- neg_le_of_abs_le
- sub_le_of_abs_sub_le_left
- sub_le_of_abs_sub_le_right
- sub_lt_of_abs_sub_lt_left
- sub_lt_of_abs_sub_lt_right

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 2, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 5, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 5, 2025
@urkud urkud requested review from pechersky and YaelDillies March 14, 2025 22:06
Copy link
Collaborator

@pechersky pechersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making this more consistent.

It's too bad git diff view isn't able to well recognize exactly how to align the two file versions.

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Mar 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 15, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Order/Group/Abs): use @[to_additive] [Merged by Bors] - chore(Order/Group/Abs): use @[to_additive] Mar 15, 2025
@mathlib-bors mathlib-bors bot closed this Mar 15, 2025
@mathlib-bors mathlib-bors bot deleted the YK-mabs branch March 15, 2025 13:49
qawbecrdtey added a commit that referenced this pull request Mar 17, 2025
…vProdLpPiLp` (#22993)

* feat: scalar tower instances for quotients (#22951)

We already have the `SMulCommClass` and `IsScalarTower` versions for `RingQuot`; this develops them for `Con` and `RingCon`, with the eventual aim of replacing `RingQuot` with `RingCon.Quotient`.

* chore(Order/Group/Abs): use `@[to_additive]` (#22468)

* feat(FieldTheory/Finite/Basic): lemmas about the prime subfield in positive characteristic (#22843)

This PR adds some elementary results about the prime subfield of a characteristic p field, e.g., size is p, elements are integer multiples of one, and elements are characterized by being fixed by the p-th power map.

* docs(Data/Real/EReal): fix capitalization error (#22943)

Changes `Ereal` to `EReal` in the module docstring for `Data/Real/EReal`.

* chore(Ideal/Quotient): change `Fintype` to `Finite` (#22947)

As discussed [here](#22902 (comment))

* feat: add `norm_num` extensions for factorials (#8832)

Add `norm_num` extensions to evaluate `Nat.factorial`, `Nat.ascFactorial` and `Nat.descFactorial`.



Co-authored-by: Eric Wieser <[email protected]>

* perf(CategoryTheory/Limits/Shapes): reorder instance arguments (#22968)

This PR is in the same spirit as #22953.

The problem is that some instances about category theoretical limits have silly side conditions that end up searching through the whole algebraic type class hierarchy. This PR attempts to keep the type class search limited to category theoretical type classes.

* feat(LinearAlgebra/FreeModule/CardQuotient): compute indices of subgroups via determinant (#22940)

* feat: API for continuous extension of meromorphic functions (#22867)

Defines the normal form of meromorphic functions and provides API for continuous extension, as discussed [on Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/API.20for.20continuous.20extension.20of.20meromorphic.20functions). More material will be provided in upcoming PRs.

This material is used in [Project VD](https://github.com/kebekus/ProjectVD), which aims to formalize Value Distribution Theory for meromorphic functions on the complex plane.

* feat(Data/Complex/Trigonometric): closer upper bound for cos 1 (#22945)

cos 1 is approximately 0.5403..., so this bound is fairly tight.

Co-authored-by: Vlad Tsyrklevich <[email protected]>

* chore: move `List.Lex` lemmas out of the `List.Lex` namespace (#22935)

This better matches the naming convention.

* working on it.

* Added sup_disjSum and inf_disjSum.

* Finished one branch.

* Finished proof.

---------

Co-authored-by: Eric Wieser <[email protected]>
Co-authored-by: Yury G. Kudryashov <[email protected]>
Co-authored-by: Scott Carnahan <[email protected]>
Co-authored-by: plp127 <[email protected]>
Co-authored-by: Xavier Roblot <[email protected]>
Co-authored-by: Sebastian Zimmer <[email protected]>
Co-authored-by: JovanGerb <[email protected]>
Co-authored-by: Stefan Kebekus <[email protected]>
Co-authored-by: Vlad Tsyrklevich <[email protected]>
Co-authored-by: Vlad Tsyrklevich <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants