Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Algebra/Group/Basic): rename mul_right_eq_self to mul_eq_left etc #22587

Closed
wants to merge 9 commits into from

Conversation

b-reinke
Copy link
Collaborator

@b-reinke b-reinke commented Mar 5, 2025

See discussion of #22507, apparently mul_eq_left is used more often that mul_right_eq_self for the same kind of lemma.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

PR summary 89340a3680

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ add_left_eq_self
+ add_left_ne_self
+ add_right_eq_self
+ add_right_ne_self
+ left_eq_mul
+ left_ne_mul
+ mul_eq_left
+ mul_eq_right
+ mul_ne_left
+ mul_ne_right
+ right_eq_mul
+ right_ne_mul
+ self_eq_add_left
+ self_eq_add_right
+ self_ne_add_left
+ self_ne_add_right

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Paul-Lez Paul-Lez self-requested a review March 5, 2025 13:55
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 10, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 13, 2025
Copy link
Collaborator

@Paul-Lez Paul-Lez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review - this looks good to me!

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@kim-em
Copy link
Contributor

kim-em commented Mar 13, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Mar 13, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 13, 2025
…etc (#22587)

See discussion of #22507, apparently `mul_eq_left` is used more often that `mul_right_eq_self` for the same kind of lemma.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Group/Basic): rename mul_right_eq_self to mul_eq_left etc [Merged by Bors] - chore(Algebra/Group/Basic): rename mul_right_eq_self to mul_eq_left etc Mar 14, 2025
@mathlib-bors mathlib-bors bot closed this Mar 14, 2025
@mathlib-bors mathlib-bors bot deleted the b-reinke/mul_left_eq_self branch March 14, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants