Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: more lemmas on NatOrdinal #22616

Closed
wants to merge 6 commits into from
Closed

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Mar 6, 2025

We port some more results on Ordinal into NatOrdinal.
Used within the CGT repo.


Open in Gitpod

Copy link

github-actions bot commented Mar 6, 2025

PR summary 61953c66c8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ add_le_iff
+ instance : CharZero NatOrdinal
+ lt_add_iff
+ lt_mul_iff
+ lt_one_iff_zero
+ mul_add_lt
+ mul_le_iff
+ nmul_nadd_le
+ not_lt_zero
+ small_Icc
+ small_Ico
+ small_Iic
+ small_Iio
+ small_Ioc
+ small_Ioo
+ toNatOrdinal_natCast
+ toOrdinal_natCast
+ zero_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp vihdzp requested a review from b-mehta March 14, 2025 15:58
@b-mehta
Copy link
Contributor

b-mehta commented Mar 14, 2025

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Mar 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 14, 2025
We port some more results on `Ordinal` into `NatOrdinal`.
Used within the CGT repo.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: more lemmas on NatOrdinal [Merged by Bors] - feat: more lemmas on NatOrdinal Mar 14, 2025
@mathlib-bors mathlib-bors bot closed this Mar 14, 2025
@mathlib-bors mathlib-bors bot deleted the vi.natOps branch March 14, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-set-theory Set theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants