[Merged by Bors] - chore(Data): go through remaining porting notes #22907
+150
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR goes through all porting notes in `Mathlib/Data` and reviews them. Most of the notes can simply be applied or dropped.
Vierkantor
added
awaiting-CI
porting-notes
PR summary d566427954Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 2078 | -166 | porting notes |
| 1186 | -3 | erw |
Current commit d566427954
Reference commit eaf100acc5
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
jcommelin
reviewed
Mar 14, 2025
| -- Porting note: added | ||
| inl.injEq, inr.injEq, reduceCtorEq] | ||
| ) | ||
| rintro (a | a) (b | b) (c | c) <;> simp) |
leanprover-community-mathlib4-bot
added
the
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
This PR goes through all porting notes in `Mathlib/Data` and reviews them. Most of the notes can simply be applied or dropped.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Vierkantor
added a commit
that referenced
this pull request
Mar 15, 2025
This fixes two major performance regressions I accidentally introduced in #22907: * in `Data.PFun`, `aesop` was very slow to prove a goal, restore manual proof * in `Data.Sign`, I turned a `CoeTC SignType ɑ` instance into `Coe SignType ɑ` (since `CoeTC` is an implementation detail), but this would mean that for any coercion to `ɑ` we'd try `SignType` as an intermediate step. Instead make it a `CoeTail` so it would only be applied as a fallback.
Vierkantor
added a commit
that referenced
this pull request
Mar 17, 2025
This fixes two major performance regressions I accidentally introduced in #22907: * in `Data.PFun`, `aesop` was very slow to prove a goal, restore manual proof * in `Data.Sign`, I turned a `CoeTC SignType ɑ` instance into `Coe SignType ɑ` (since `CoeTC` is an implementation detail), but this would mean that for any coercion to `ɑ` we'd try `SignType` as an intermediate step. Instead make it a `CoeTail` so it would only be applied as a fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes through all porting notes in
Mathlib/Dataand reviews them. Most of the notes can simply be applied or dropped.