-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(Algebra/Group/Subgroup/Basic): clean up normalizer lemmas #22913
Conversation
PR summary 8bbe260b53Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Mathlib/Order/Lattice.lean
Outdated
@@ -127,6 +127,10 @@ theorem sup_le_iff : a ⊔ b ≤ c ↔ a ≤ c ∧ b ≤ c := | |||
⟨fun h : a ⊔ b ≤ c => ⟨le_trans le_sup_left h, le_trans le_sup_right h⟩, | |||
fun ⟨h₁, h₂⟩ => sup_le h₁ h₂⟩ | |||
|
|||
@[simp] | |||
theorem sup_self : a ⊔ a = a := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this already exists as sup_idem
(and similarly for the inf lemma below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mod the comment about sup_idem
.
bors d+
✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
…22913) This PR cleans up several normalizer lemmas in `Algebra/Group/Subgroup/Basic`. Several lemmas had unnecessary assumptions or unnecessarily complicated proofs.
Pull request successfully merged into master. Build succeeded: |
This PR cleans up several normalizer lemmas in
Algebra/Group/Subgroup/Basic
. Several lemmas had unnecessary assumptions or unnecessarily complicated proofs.