Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(Algebra/Group/Subgroup/Basic): clean up normalizer lemmas #22913

Closed
wants to merge 5 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Mar 14, 2025

This PR cleans up several normalizer lemmas in Algebra/Group/Subgroup/Basic. Several lemmas had unnecessary assumptions or unnecessarily complicated proofs.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI t-algebra Algebra (groups, rings, fields, etc) labels Mar 14, 2025
Copy link

github-actions bot commented Mar 14, 2025

PR summary 8bbe260b53

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.AddSubgroup.comap_normalizer_eq_of_injective_of_le_range
+ comap_normalizer_eq_of_le_range
+ inf_normalizer_le_normalizer_inf
+ normal_subgroupOf_iff_le_normalizer
+ normal_subgroupOf_iff_le_normalizer_inf

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@@ -127,6 +127,10 @@ theorem sup_le_iff : a ⊔ b ≤ c ↔ a ≤ c ∧ b ≤ c :=
⟨fun h : a ⊔ b ≤ c => ⟨le_trans le_sup_left h, le_trans le_sup_right h⟩,
fun ⟨h₁, h₂⟩ => sup_le h₁ h₂⟩

@[simp]
theorem sup_self : a ⊔ a = a := by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this already exists as sup_idem (and similarly for the inf lemma below).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks!

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mod the comment about sup_idem.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 14, 2025

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg grunweg changed the title refactor(Algebra/Group/Subgroup/Basic): Clean up normalizer lemmas refactor(Algebra/Group/Subgroup/Basic): clean up normalizer lemmas Mar 14, 2025
@tb65536
Copy link
Collaborator Author

tb65536 commented Mar 14, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 14, 2025
…22913)

This PR cleans up several normalizer lemmas in `Algebra/Group/Subgroup/Basic`. Several lemmas had unnecessary assumptions or unnecessarily complicated proofs.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Algebra/Group/Subgroup/Basic): clean up normalizer lemmas [Merged by Bors] - refactor(Algebra/Group/Subgroup/Basic): clean up normalizer lemmas Mar 14, 2025
@mathlib-bors mathlib-bors bot closed this Mar 14, 2025
@mathlib-bors mathlib-bors bot deleted the tb_subgroupof branch March 14, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants