Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: move Nat.count_le_cardinal, add variants #22938

Closed
wants to merge 1 commit into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator


Open in Gitpod

Copy link

PR summary 34aae0d0fa

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Nat.Count 688 532 -156 (-22.67%)
Mathlib.Data.Nat.Nth 707 654 -53 (-7.50%)
Import changes for all files
Files Import difference
Mathlib.Data.Nat.Count -156
Mathlib.Data.Int.CardIntervalMod -84
Mathlib.Data.Nat.Nth Mathlib.Data.Nat.Prime.Nth -53
Mathlib.SetTheory.Cardinal.NatCount (new file) 717

Declarations diff

+ count_le_setENCard
+ count_le_setNCard

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@@ -5,7 +5,7 @@ Authors: Yaël Dillies, Vladimir Goryachev, Kyle Miller, Kim Morrison, Eric Rodr
-/
import Mathlib.Algebra.Group.Nat.Range
import Mathlib.Algebra.Order.Ring.Nat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can get reduce this import too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, but I'll leave that for a next PR

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@fpvandoorn
Copy link
Member

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Mar 15, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: move Nat.count_le_cardinal, add variants [Merged by Bors] - feat: move Nat.count_le_cardinal, add variants Mar 15, 2025
@mathlib-bors mathlib-bors bot closed this Mar 15, 2025
@mathlib-bors mathlib-bors bot deleted the count_le_cardinal branch March 15, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants