Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: add missing no_index around OfNat.ofNat #8317

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - fix: add missing no_index around OfNat.ofNat #8317

wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Nov 10, 2023 •
edited by github-actions bot
Loading

@eric-wieser eric-wieser added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) awaiting-review awaiting-CI labels Nov 10, 2023
@eric-wieser eric-wieser mentioned this pull request Nov 10, 2023
Closed
1 task
@eric-wieser
Copy link
Member Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit dfb9ef9.
There were no significant changes against commit 7a1bf93.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 10, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@timotree3 timotree3 mentioned this pull request Nov 12, 2023
Open
1 task
jcommelin
jcommelin approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 4, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 4, 2023
@eric-wieser @timotree3
fix: add missing no_index around OfNat.ofNat (#8317)
070be71 
Co-authored-by: timotree3 <[email protected]>



Co-authored-by: timotree3 <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 4, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: add missing no_index around OfNat.ofNat [Merged by Bors] - fix: add missing no_index around OfNat.ofNat Dec 4, 2023
@mathlib-bors mathlib-bors bot closed this Dec 4, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/noindex-fixes branch December 4, 2023 13:54
awueth pushed a commit that referenced this pull request Dec 19, 2023
@eric-wieser @timotree3 @awueth
fix: add missing no_index around OfNat.ofNat (#8317)
6513764 
Co-authored-by: timotree3 <[email protected]>



Co-authored-by: timotree3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@timotree3 timotree3 timotree3 approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eric-wieser @leanprover-bot @leanprover-community-mathlib4-bot @jcommelin @timotree3