Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Function/Conjugate): add Semiconj.inverse_left #9724

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 13, 2024

  • Add Function.semiconj_iff_comp_eq
    and Function.Semiconj.inverse_left.
  • Swap arguments of Function.Semiconj.comp_left.
    The old version is available as Function.Semiconj.trans.
  • Add docstrings.

Open in Gitpod

* Add `Function.semiconj_iff_comp_eq`
  and `Function.Semiconj.inverse_left`.
* Swap arguments of `Function.Semiconj.comp_left`.
  The old version is available as `Function.Semiconj.trans`.
* Add docstrings.
@urkud urkud added awaiting-review t-logic Logic (model theory, etc) labels Jan 13, 2024
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

#align function.semiconj.inverses_right Function.Semiconj.inverses_right

/-- If `f` semiconjugates `ga` to `gb` and `f'` is both a left and a right inverse of `f`,
then `f'` semiconjugates `gb` to `ga`. -/
lemma inverse_left {f' : β → α} (h : Semiconj f ga gb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other lemma is called inverses_right (note the s). Can you uniformize between the two?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR, my intention was to say that in case of inverses_right, we inverse 2 functions. Should I rename to inverse_right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge as is and open another PR if needed.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud
Copy link
Member Author

urkud commented Jan 16, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2024
* Add `Function.semiconj_iff_comp_eq`
  and `Function.Semiconj.inverse_left`.
* Swap arguments of `Function.Semiconj.comp_left`.
  The old version is available as `Function.Semiconj.trans`.
* Add docstrings.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Function/Conjugate): add Semiconj.inverse_left [Merged by Bors] - feat(Function/Conjugate): add Semiconj.inverse_left Jan 16, 2024
@mathlib-bors mathlib-bors bot closed this Jan 16, 2024
@mathlib-bors mathlib-bors bot deleted the YK-semiconj branch January 16, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants