-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Function/Conjugate): add Semiconj.inverse_left
#9724
Conversation
* Add `Function.semiconj_iff_comp_eq` and `Function.Semiconj.inverse_left`. * Swap arguments of `Function.Semiconj.comp_left`. The old version is available as `Function.Semiconj.trans`. * Add docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks!
#align function.semiconj.inverses_right Function.Semiconj.inverses_right | ||
|
||
/-- If `f` semiconjugates `ga` to `gb` and `f'` is both a left and a right inverse of `f`, | ||
then `f'` semiconjugates `gb` to `ga`. -/ | ||
lemma inverse_left {f' : β → α} (h : Semiconj f ga gb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other lemma is called inverses_right
(note the s
). Can you uniformize between the two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIR, my intention was to say that in case of inverses_right
, we inverse 2 functions. Should I rename to inverse_right
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge as is and open another PR if needed.
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
* Add `Function.semiconj_iff_comp_eq` and `Function.Semiconj.inverse_left`. * Swap arguments of `Function.Semiconj.comp_left`. The old version is available as `Function.Semiconj.trans`. * Add docstrings.
Pull request successfully merged into master. Build succeeded: |
Semiconj.inverse_left
Semiconj.inverse_left
Function.semiconj_iff_comp_eq
and
Function.Semiconj.inverse_left
.Function.Semiconj.comp_left
.The old version is available as
Function.Semiconj.trans
.