Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/AddConstMap): new file #9725

Closed
wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 13, 2024


I have more (AddConstEquivs, order, monotone maps) in a branch.

Open in Gitpod

@urkud urkud added awaiting-review t-algebra Algebra (groups, rings, fields, etc) t-dynamics Dynamical Systems t-order Order theory and removed t-order Order theory labels Jan 13, 2024
@urkud urkud requested a review from sgouezel January 16, 2024 08:25
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jan 16, 2024
@urkud urkud added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 17, 2024
@urkud urkud requested a review from sgouezel January 22, 2024 14:50
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!


theorem map_add_ofNat [AddMonoidWithOne G] [AddMonoidWithOne H] [AddConstMapClass F G H 1 1]
(f : F) (x : G) (n : ℕ) [n.AtLeastTwo] :
f (x + no_index (OfNat.ofNat n)) = f x + OfNat.ofNat n := map_add_nat f x n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the no_index here: it is only relevant for simp lemmas. Same thing below.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 22, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud
Copy link
Member Author

urkud commented Jan 23, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 23, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/AddConstMap): new file [Merged by Bors] - feat(Algebra/AddConstMap): new file Jan 23, 2024
@mathlib-bors mathlib-bors bot closed this Jan 23, 2024
@mathlib-bors mathlib-bors bot deleted the YK-add-const-map branch January 23, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-dynamics Dynamical Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants