feat: System.Platform.target #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
This combines a few platform-related changes: * Add a ternary `platformIndependent` Lean configuration option to assert whether Lake should assume Lean code is platform-independent. If `true`, Lake will exclude platform-independent objects like external libraries or dynlibs created through `precompileModules` from module traces. If `false`, Lake will add the platform to module traces. If `none` (the default), Lake will retain the current behavior (modules are platform-dependent if and only if it depends on native objects). * Use `System.Platform.target` from #3207 as the platform descriptor in Lake for the configuration file trace, the cloud release archive, and as the platform trace in Lean modules and native artifacts (e.g., object files, and static and shared libraries). * Do not add the platform descriptor into custom build archive names (i.e., a user-set `buildArchive` configuration). This allows users to create cross-platform / platform-independent archives via a name override should they so desire. Closes #2754.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the LLVM triple of the current platform available to Lean code towards a solution for #2754.
Defaults to the empty string if the compiler is not clang, which can introduce some divergence between CI and local builds but should not be noticeable in most cases and is not really possible to avoid.