fix: update LazyDiscrTree to not reuse names when caching #3610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue discovered in Mathlib with the meta cache being poisoned by using a name generator. It is difficult to reproduce due to the name collisions being rare, but here is a minimal module with definitions that result in an error:
Removing any of thee last 5 definitions avoids the error. Testing against Mathlib shows this PR fixes the issue.