Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit Lean.MVarId.withReverted #3743

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Mar 22, 2024

When it was upstreamed, it lost the mention of "revert/intro pattern", which is helpful for finding this function. Also extended the description of the function and clarified some points.

When it was upstreamed, it lost "revert/intro pattern", which is helpful for finding this function. Also extended the description of the function and clarified some points.
@kmill kmill added the awaiting-review Waiting for someone to review the PR label Mar 22, 2024
@kmill kmill requested a review from leodemoura as a code owner March 22, 2024 20:16
@kmill kmill changed the title docs: Lean.MVarId.withReverted doc: edit Lean.MVarId.withReverted Mar 22, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 8ce98e62ac82379caaa4e76243e8f4ac3fccf366 --onto d5a1dce0ae92475c73a9c24fc8fb2c8e0d4acbcd. (2024-03-22 20:33:18)

Copy link
Collaborator

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kim-em kim-em enabled auto-merge March 26, 2024 05:38
@kim-em
Copy link
Collaborator

kim-em commented Mar 28, 2024

CI got stuck.

@kim-em kim-em added this pull request to the merge queue Mar 28, 2024
Merged via the queue into leanprover:master with commit 5167324 Mar 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants