Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #print command shows structure fields #3768

Merged
merged 15 commits into from
Apr 24, 2024
Merged

feat: #print command shows structure fields #3768

merged 15 commits into from
Apr 24, 2024

Conversation

fgdorais
Copy link
Contributor

@fgdorais fgdorais commented Mar 26, 2024 •
edited
Loading

See RFC #3644 for a discussion of design choices.

Closes #3644

@fgdorais fgdorais marked this pull request as draft March 26, 2024 03:39
@fgdorais fgdorais mentioned this pull request Mar 26, 2024
Closed
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 26, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Mar 26, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 22b5c957e9706426f0ee26ca6a541e6ee6f2c2aa --onto 80d2455b6401acf6b0d107388b814c175e64c0d3. (2024-03-26 03:55:57)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d95e74182413627ec88395f36d31f47ce4c189ad --onto 62cdb51ed5b9d8487877d5a4adbcd4659d81fc6a. (2024-04-23 13:37:26)

kim-em
kim-em reviewed Apr 22, 2024
View reviewed changes
kim-em
kim-em reviewed Apr 22, 2024
View reviewed changes
@kim-em
Copy link
Collaborator

kim-em commented Apr 22, 2024

Happy to proceed with this, if you want to make the changes and mark as awaiting-review!

@kim-em kim-em self-assigned this Apr 22, 2024
@fgdorais fgdorais marked this pull request as ready for review April 23, 2024 13:21
@fgdorais
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Apr 23, 2024
@kim-em kim-em added this pull request to the merge queue Apr 24, 2024
Merged via the queue into leanprover:master with commit 05b6868 Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em left review comments

Assignees

@kim-em kim-em

Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: have #print display structure fields
3 participants
@fgdorais @leanprover-community-mathlib4-bot @kim-em