perf: isDefEq performance issue
#3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
This was referenced Apr 2, 2024
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 2, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <[email protected]>
kim-em
added a commit
that referenced
this pull request
Apr 6, 2024
kim-em
added a commit
that referenced
this pull request
Apr 6, 2024
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 10, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷♀️ Co-authored-by: Scott Morrison <[email protected]>
Louddy
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 15, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <[email protected]>
Louddy
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 15, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷♀️ Co-authored-by: Scott Morrison <[email protected]>
atarnoam
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 16, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <[email protected]>
atarnoam
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 16, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷♀️ Co-authored-by: Scott Morrison <[email protected]>
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 18, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷♀️ Co-authored-by: Scott Morrison <[email protected]>
This was referenced Apr 18, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 18, 2024
This is the PR to `bump/v4.8.0`, bringing us up from `nightly-2024-03-24` to `nightly-2024-04-07` (so almost two weeks). Note that the release of v4.8.0-rc1 has been delayed because of remaining issues: This PR contains a number of `set_option maxHeartbeats ...` or `@[nolint simpNF]` which are required by heartbeats errors. These are due to changes to `IsDefEq` from leanprover/lean4#3807. So far, the ones I've looked in detail have revealed some problems where we are probably abusing defeq a bit, so I would appreciate any available eyes on these to see which ones ought to be fixed in Mathlib, and which ones are problematic. It's been a long road to keep `nightly-testing` alive, and some big refactors have been landing on `master`, and I'm sure there are mistakes in how I've merged things here, so please be gentle if I've messed things up (and in particular feel free to revert changes that look like mistakes, as long as you test them!). :-) --------- Co-authored-by: Ruben Van de Velde <[email protected]> Co-authored-by: María Inés de Frutos-Fernández <[email protected]> Co-authored-by: María Inés de Frutos-Fernández <[email protected]> Co-authored-by: Parcly Taxel <[email protected]> Co-authored-by: Johan Commelin <[email protected]>
uniwuni
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 19, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <[email protected]>
uniwuni
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 19, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷♀️ Co-authored-by: Scott Morrison <[email protected]>
leodemoura
pushed a commit
that referenced
this pull request
Apr 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
This is intended to fail at present: it just adds a test case containing a minimization of a Mathlib slowdown from #3807. Prior to #3807, the declaration `exists_algHom_adjoin_of_splits'''` at the end of the file would take around 16,000 heartbeats. Now it takes around 210,000 heartbeats. --------- Co-authored-by: Leonardo de Moura <[email protected]>
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <[email protected]>
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷♀️ Co-authored-by: Scott Morrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a performance problem found by @hargoniX while working on LeanSAT.