Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: ensure linearity in Parsec.many*Core #3830

Merged
merged 1 commit into from
Apr 22, 2024
Merged

perf: ensure linearity in Parsec.many*Core #3830

merged 1 commit into from
Apr 22, 2024

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Apr 3, 2024 •
edited
Loading

No description provided.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 3, 2024 13:05 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 3, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Apr 3, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-04-03 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-04-03 13:19:55)
  • ✅ Mathlib branch lean-pr-testing-3830 has successfully built against this PR. (2024-04-04 09:46:23) View Log
  • ✅ Mathlib branch lean-pr-testing-3830 has successfully built against this PR. (2024-04-04 10:28:32) View Log

@hargoniX hargoniX force-pushed the parsec-linearity branch 3 times, most recently from 38c2bf2 to 875de03 Compare April 3, 2024 13:44
@hargoniX
Copy link
Contributor Author

hargoniX commented Apr 3, 2024

!bench

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 3, 2024 13:58 Inactive
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 875de03.
There were significant changes against commit f3121b0:

  Benchmark   Metric          Change
  ===========================================
- stdlib      type checking     1.3% (31.0 σ)

@hargoniX
perf: ensure linearity in Parsec.many*Core
334e698 
Inlined the orElse combinator into Parsec.many*Core in order to ensure
linearity on the accumulator.
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 4, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3830
78a2d6a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 4, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3830
8163e2c
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 4, 2024 08:47 Inactive
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Apr 4, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 4, 2024 09:48 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3830
b2d43cb
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3830
e5dd7aa
@Kha Kha added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 5, 2024
@kim-em kim-em added this pull request to the merge queue Apr 22, 2024
Merged via the queue into master with commit 263c93a Apr 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hargoniX @leanprover-community-mathlib4-bot @leanprover-bot @kim-em