feat: universe constraint approximations #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add a new configuration flag for `isDefEq`: `Meta.Config.univApprox`. When it is true, we approximate the solution for universe constraints such as - `u =?= max u ?v`, we use `?v := u`, and ignore the solution `?v := 0`. - `max u v =?= max u ?w`, we use `?w := v`, and ignore the solution `?w := max u v`. We only apply these approximations when there the contraints cannot be postponed anymore. These approximations prevent error messages such as ``` error: stuck at solving universe constraint max u ?u.3430 =?= u ``` This kind of error seems to appear in several Mathlib files. We currently do not use these approximations while synthesizing type class instances.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
This was referenced Apr 24, 2024
7 tasks
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 2, 2024
…2599) They are no longer necessary after [#3981](leanprover/lean4#3981)
apnelson1
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 12, 2024
…2599) They are no longer necessary after [#3981](leanprover/lean4#3981)
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2024
…2599) They are no longer necessary after [#3981](leanprover/lean4#3981)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new configuration flag for
isDefEq:Meta.Config.univApprox.When it is true, we approximate the solution for universe constraints such as
u =?= max u ?v, we use?v := u, and ignore the solution?v := 0.max u v =?= max u ?w, we use?w := v, and ignore the solution?w := max u v.We only apply these approximations when there the contraints cannot be postponed anymore. These approximations prevent error messages such as
This kind of error seems to appear in several Mathlib files.
We currently do not use these approximations while synthesizing type class instances.