fix: use correct expr positions when delaborating match patterns
#4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following, hovering over `true` in the infoview was showing `Nat.succ y`. ```lean #check fun (x : Nat) => match h : x with | 0 => false | y + 1 => true ``` Now hovering over `true` shows `true`. The issue was that SubExpr positions were not being tracked for patterns and the position for a pattern could coincide with the pattern for a RHS. Now the position given to a pattern is an argument to a motive in a minor premise in the type of the head of the match expression.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following, hovering over
truein the infoview was showingNat.succ y.Now hovering over
trueshowstrue.The issue was that SubExpr positions were not being tracked for patterns, and the position for a pattern could coincide with the position for a RHS, putting overwriting terminfo. Now the position given to a pattern is correct and unique.
Refactors the
matchdelaborator, makes it handle shadowing ofh :discriminant annotations correctly, and makes it use the standardwithOverAppcombinator to handle overapplication.