refactor: do not try rfl in mkEqnTypes in WF.mkEqns #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems to help with problems that arise in #4002, so I am curious about its effects (if any) on its own. It could lead to * faster `mkEqnTypes`, if in the well-founded case the `tryURefl` never hits (in which case we should probaby skip that altogether) * more fine-grained equational lemams, if the `tryURefl` did trigger
…to joachim/eqnTypes-no-rfl
when dealing with well-founded recursive definitions, `tryURefl` isn't going to be that useful and possibly slow. So disable that code path when doing well-founded recursion. (This is a variant of #4025 where I tried using `with_reducible` to limit the impact of slow unfolding, but if we can get away with disabling it complete, then even better.)
nomeata
changed the title
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 1, 2024
|
!bench |
|
Mathlib perf results: http://speed.lean-fro.org/mathlib4/compare/d263df69-867e-4d8e-b1b0-3f3ff0c077c9/to/029cb476-33f2-4227-84be-3ad9be09f0b8 |
|
Here are the benchmark results for commit 4606f1a. |
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when dealing with well-founded recursive definitions,
tryUReflisn'tgoing to be that useful and possibly slow. So disable that code path
when doing well-founded recursion.
(This is a variant of #4025 where I tried using
with_reducibletolimit the impact of slow unfolding, but if we can get away with
disabling it complete, then even better.)