fix: type class issues #4114
Closed
fix: type class issues #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 9, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 9, 2024
leanprover-community-mathlib4-bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 9, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 9, 2024
|
Speedcenter results on Mathlib (comparing against nightly-testing-2024-05-08, i.e. no changes except this change to Lean, and the two minor adaptations in Mathlib) are available at http://speed.lean-fro.org/mathlib4/compare/74df3d57-7d3a-4c8a-870b-ed5b8ccd5802/to/e7b27246-a3e6-496a-b552-ff4b45c7236e?hash2=fd58d1bdbcaeb92b91d2d047c4a4d4572fda2162. Unfortunately they are bad: +1.3% instructions, +2.4% wall clock. |
|
Closing in favour of #4119 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 14, 2024
Summary: - Take `synthPendingDepth` into account when caching TC results - Add `maxSynthPendingDepth` option with default := 2. - Add support for tracking `synthPending` failures when using `set_option diagnostics true` closes #2522 closes #3313 closes #3927 Identical to #4114 but with `maxSynthPendingDepth := 1` closes #4114 cc @semorrison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
synthPendingDepthinto account when caching TC resultsmaxSynthPendingDepthoption with default := 2.synthPendingfailures when usingset_option diagnostics truecloses #2522
closes #3313
closes #3927