Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lake: build monitor improvements #4127

Merged
merged 9 commits into from
May 18, 2024
Merged

feat: lake: build monitor improvements #4127

merged 9 commits into from
May 18, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented May 10, 2024 •
edited
Loading

The new Lake build monitor is now more selective, accurate, and prettier in what it prints.

Key Changes:

  • Poll jobs at a fixed frequency (100ms), updating the caption and finished job count.
  • Add action field to jobs to record information about what jobs do. It enables distinguishing between jobs which build something, fetch from a store, or reload logs from the cache.
  • At standard verbosity, print build captions only when a job is know to build or fetch something (i.e., action >= .fetch).
  • Add an icon and color to job captions based on their log-level / build status. Also add color to levels in logs.
  • Add --ansi/--no-ansi to toggle Lake's use of ANSI escape codes.
  • Fix some v4.8.0-rc1 bugs and --old.

Closes #2822.

@tydeu tydeu added this to the v4.8.0-rc2 milestone May 10, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 10, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 10, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4127
9cb844e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 10, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4127
2eae1f5
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented May 11, 2024 •
edited
Loading

Mathlib CI status (docs):

@tydeu tydeu force-pushed the lake/build-monitor+ branch from e29c178 to 36554e7 Compare May 14, 2024 18:40
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 14, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
4d6b4f5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 14, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
5d26c42
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 15, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
e9a217b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 15, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
3a6e80a
@tydeu tydeu force-pushed the lake/build-monitor+ branch from 644e31b to 836e894 Compare May 15, 2024 16:35
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 15, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
c6ea92f
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 15, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
560aba6
@kim-em kim-em mentioned this pull request May 15, 2024
Closed
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 15, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
b9ea65e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 15, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
c75d080
@tydeu tydeu force-pushed the lake/build-monitor+ branch from de41c50 to 58242d8 Compare May 16, 2024 03:42
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
13195cb
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
a1bfcd2
@tydeu tydeu force-pushed the lake/build-monitor+ branch from a283417 to d3fef62 Compare May 16, 2024 18:32
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
c78f28b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
50fc572
@tydeu tydeu force-pushed the lake/build-monitor+ branch from d3fef62 to abb003d Compare May 16, 2024 18:58
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
086c1aa
@tydeu tydeu force-pushed the lake/build-monitor+ branch from 87a5e63 to 44e398a Compare May 17, 2024 01:13
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 17, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
9f02a62
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 17, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
9c93d82
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 17, 2024
@tydeu tydeu marked this pull request as ready for review May 17, 2024 02:51
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 17, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
5bd68c3
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 17, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
9112cea
@tydeu tydeu added the full-ci label May 17, 2024
@tydeu tydeu force-pushed the lake/build-monitor+ branch from bd02fb6 to 706ab5e Compare May 17, 2024 03:43
@tydeu tydeu force-pushed the lake/build-monitor+ branch from 706ab5e to 5094d0f Compare May 17, 2024 04:18
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 17, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
9ad1ba7
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 17, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
e444582
@tydeu tydeu added the will-merge-soon …unless someone speaks up label May 17, 2024
@tydeu tydeu force-pushed the lake/build-monitor+ branch from bb2222d to d1e99dc Compare May 17, 2024 20:03
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 17, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
36a6cd3
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 17, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4127
1c46e70
@tydeu tydeu added this pull request to the merge queue May 17, 2024
Merged via the queue into leanprover:master with commit 7648bf2 May 18, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request May 18, 2024
@tydeu @github-actions
feat: lake: build monitor improvements (#4127)
0f43ef1 
The new Lake build monitor is now more selective, accurate, and prettier
in what it prints.

**Key Changes:**

* Poll jobs at a fixed frequency (100ms), updating the caption and
finished job count.
* Add `action` field to jobs to record information about what jobs do.
It enables distinguishing between jobs which build something, fetch from
a store, or reload logs from the cache.
* At standard verbosity, print build captions only when a job is know to
build or fetch something (i.e., `action >= .fetch`).
* Add an icon and color to job captions based on their log-level / build
status. Also add color to levels in logs.
* Add `--ansi`/`--no-ansi` to toggle Lake's use of ANSI escape codes.
* Fix some `v4.8.0-rc1` bugs and `--old`.

Closes #2822.

(cherry picked from commit 7648bf2)
@github-actions github-actions bot mentioned this pull request May 18, 2024
Merged
@tydeu tydeu deleted the lake/build-monitor+ branch May 18, 2024 01:48
@tydeu tydeu mentioned this pull request May 18, 2024
Closed
tydeu added a commit that referenced this pull request May 18, 2024
@tydeu
feat: lake: build monitor improvements (#4127)
beca6a7 
The new Lake build monitor is now more selective, accurate, and prettier
in what it prints.

**Key Changes:**

* Poll jobs at a fixed frequency (100ms), updating the caption and
finished job count.
* Add `action` field to jobs to record information about what jobs do.
It enables distinguishing between jobs which build something, fetch from
a store, or reload logs from the cache.
* At standard verbosity, print build captions only when a job is know to
build or fetch something (i.e., `action >= .fetch`).
* Add an icon and color to job captions based on their log-level / build
status. Also add color to levels in logs.
* Add `--ansi`/`--no-ansi` to toggle Lake's use of ANSI escape codes.
* Fix some `v4.8.0-rc1` bugs and `--old`.

Closes #2822.

(cherry picked from commit 7648bf2)
@tydeu tydeu mentioned this pull request May 20, 2024
Closed
1 task
kim-em pushed a commit that referenced this pull request May 21, 2024
@tydeu @kim-em
feat: lake: build monitor improvements (#4127)
5816315 
The new Lake build monitor is now more selective, accurate, and prettier
in what it prints.

**Key Changes:**

* Poll jobs at a fixed frequency (100ms), updating the caption and
finished job count.
* Add `action` field to jobs to record information about what jobs do.
It enables distinguishing between jobs which build something, fetch from
a store, or reload logs from the cache.
* At standard verbosity, print build captions only when a job is know to
build or fetch something (i.e., `action >= .fetch`).
* Add an icon and color to job captions based on their log-level / build
status. Also add color to levels in logs.
* Add `--ansi`/`--no-ansi` to toggle Lake's use of ANSI escape codes.
* Fix some `v4.8.0-rc1` bugs and `--old`.

Closes #2822.

(cherry picked from commit 7648bf2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport releases/v4.8.0 builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
v4.8.0-rc2
Development

Successfully merging this pull request may close these issues.

Lake: --old doesn't seem to work
2 participants
@tydeu @leanprover-community-mathlib4-bot