-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: variable
must execute pending tactics and elaboration problems
#4370
Conversation
@semorrison This PR may affect Mathlib. If there are too many issues, we should just skip this PR and fix the issues above when we address RFC #2452 |
Mathlib CI status (docs):
|
@leodemoura, the fallout in Mathlib is manageable. The only change is that we can no longer change the explicitness of a variable, and in the same line introduce a new variable that depends on it. (I'm not sure if that is an intended or avoidable effect of this PR!) |
Mathlib should build now. Diff is at leanprover-community/mathlib4@026f1b9 for reference. |
This was often a footgun in mathlib anyway, as sometimes it resulted in duplicate hypotheses. |
Thanks for feedback. So, I will go ahead and merge the PR. |
closes #2226
closes #3214