Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: USE_LAKE: integrate into CMake #4466

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Conversation

Kha
Copy link
Member

@Kha Kha commented Jun 16, 2024

Proof of concept built while at GPN. With USE_LAKE=ON, only linking is now left to the Makefile.

  • Moved lib/temp/lib*.a.export to lib/lean/ as Lake puts both versions in the same place, excluded from install with a glob instead
  • Mostly eliminated leanc.sh as Lake expects bin/leanc, used only as a trivial wrapper in stage0/bin now.

TODO:

  • include stage 0 changes in Lake's trace. This is an issue already on master but prevents us from using this PR to put .oleans in an Actions cache.

@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Jun 16, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 16, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-06-16 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-06-16 20:02:30)

@Kha Kha force-pushed the lake-in-cmake branch 3 times, most recently from 22cf5f2 to 4ddb049 Compare March 2, 2025 18:29
@Kha Kha force-pushed the lake-in-cmake branch from 4ddb049 to 3530f01 Compare March 2, 2025 19:42
@Kha Kha force-pushed the lake-in-cmake branch from bcfa3ec to 87f8150 Compare March 2, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants