feat: additional lemmas for Option #4599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
kim-em
reviewed
Jul 2, 2024
Comment on lines
+164
to
+168
| theorem isSome_map {x : Option α} : (f <$> x).isSome = x.isSome := by | ||
| cases x <;> simp | ||
|
|
||
| @[simp] theorem isSome_map' {x : Option α} : (x.map f).isSome = x.isSome := by | ||
| cases x <;> simp |
There was a problem hiding this comment.
Let's not now, but I wonder if we should reverse all these names, and preserve the ' for the lemmas that go via the monad.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
### Preliminary PRs: - [x] #4597 - [x] #4599 - [x] #4600 - [x] #4602 - [x] #4603 - [x] #4604 - [x] #4605 - [x] #4607 - [x] #4627 - [x] #4629 ### Quick overview over API/naming changes compared to `Lean.HashMap` and `Batteries.HashMap`: #### Lean * `find?` -> `get?`/`getElem?` * `find!` -> `get!`/`gtetElem!` * `findD` -> `getD` * `findEntry?` -> not implemented for now * `insert'` -> `containsThenInsert` (order reversed in result) * `insertIfNew` -> `getThenInsertIfNew?` (order reversed in result) * `numBuckets` -> `Internal.numBuckets` * `ofListWith` -> not implemented for now * `Array.groupByKey` -> not implemented for now * `merge` -> not implemented for now, but you can use `insertMany` #### Batteries * `modify` -> not implemented for now * `mergeWith` -> not implemented for now * `mergeWithM` -> not implemented for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4583
Mathlib has
isSome_map'but calls itisSome_map.