-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: InductiveVal.numNested
instead of .isNested
#4684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InductiveVal.numNested
instead of .isNested
(This includes #4683, diff will be prettier once that’s merged.) |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 8, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 8, 2024
d080014
to
2f02c30
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 8, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 8, 2024
Mathlib CI status (docs):
|
right now, in order to find out how many auxilary datatype are in a mutual group of inductive with nested data type, one has to jump through hoops like this: ``` private def numNestedInducts (indName : Name) : MetaM Nat := do let .inductInfo indVal ← getConstInfo indName | panic! "{indName} is an inductive" let .recInfo recVal ← getConstInfo (mkRecName indName) | panic! "{indName} has a recursor" return recVal.numMotives - indVal.all.lengt ``` The `InductiveVal` data structure already has `.isNested : Bool`, so it seems to be a natural extension to beef that up to `.numNested: Nat`. This touched kernel code.
2f02c30
to
51f799e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changes-stage0
Contains stage0 changes, merge manually using rebase
merge-ci
Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms.
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
will-merge-soon
…unless someone speaks up
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, in order to find out how many auxilary datatype are in a
mutual group of inductive with nested data type, one had to jump
through hoops like this:
The
InductiveVal
data structure already has.isNested : Bool
, so itseems to be a natural extension to beef that up to
.numNested: Nat
.This touched kernel code.