Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing assignment validation at closeMainGoal #4777

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix: missing assignment validation at closeMainGoal #4777

merged 2 commits into from
Jul 17, 2024

Conversation

leodemoura
Copy link
Member

This primitive is used by the exact tactic. This issue allowed users
to create loops in the metavariable assignment.

closes #4773

@leodemoura
fix: missing assignment validation at closeMainGoal
a8bdc5f 
This primitive is used by the `exact` tactic. This issue allowed users
to create loops in the metavariable assignment.

closes #4773
@leodemoura
chore: fix test
d533202
@leodemoura leodemoura requested a review from kim-em as a code owner July 17, 2024 18:08
@leodemoura leodemoura enabled auto-merge July 17, 2024 18:09
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 17, 2024 18:19 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jul 17, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 17, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 41b491483610a030b67535c73ccfc718776a81af --onto ba3565f441a4533490c339ead6d9ee5b1220110b. (2024-07-17 18:26:33)

Merged via the queue into master with commit be717f0 Jul 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow in instantiateExprMVars
2 participants
@leodemoura @leanprover-community-mathlib4-bot