Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove typeclass assumptions for Nodup.eraseP #4790

Merged
merged 1 commit into from
Jul 21, 2024
Merged

fix: remove typeclass assumptions for Nodup.eraseP #4790

merged 1 commit into from
Jul 21, 2024

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Jul 19, 2024

The α in the typeclass assumptions wasn't even the element type of the list.

@TwoFX TwoFX requested a review from digama0 as a code owner July 19, 2024 14:09
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 19, 2024 14:19 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 19, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 7d2155943c67c743409420b4546d47fadf73af1c --onto a94805ff71f7576ee014aafc76b29e29b066bd80. (2024-07-19 14:26:37)

@TwoFX TwoFX added this pull request to the merge queue Jul 21, 2024
Merged via the queue into master with commit 08acf5a Jul 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@kim-em kim-em Awaiting requested review from kim-em

@Vtec234 Vtec234 Awaiting requested review from Vtec234

@kmill kmill Awaiting requested review from kmill

@Kha Kha Awaiting requested review from Kha

@leodemoura leodemoura Awaiting requested review from leodemoura

@tydeu tydeu Awaiting requested review from tydeu

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoFX @leanprover-community-mathlib4-bot