Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: precise cache for expr_eq_fn #4890

Merged
merged 3 commits into from
Aug 1, 2024
Merged

perf: precise cache for expr_eq_fn #4890

merged 3 commits into from
Aug 1, 2024

Conversation

leodemoura
Copy link
Member

We also add `m_check_set` flag for controlling whether `check_cache`
should also inspect set of hashconsed objects or not.
@leodemoura
Copy link
Member Author

!bench

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 1, 2024 01:22 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 1, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase c517688f1dc3a7896049c3828d20cb615f7fd470 --onto 8acdafd5b3957382c02779ada451c14da44e2aca. (2024-08-01 01:31:31)

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 34fe8d3.
There were significant changes against commit c517688:

  Benchmark                  Metric          Change
  ============================================================
+ stdlib                     maxrss           -1.1%  (-85.5 σ)
- stdlib                     type checking     7.2% (1307.9 σ)
- tests/bench/ interpreted   maxrss            1.6%  (132.4 σ)

@leodemoura leodemoura added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit a856016 Aug 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants