-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to Std.HashMap and Std.HashSet almost everywhere #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathlib CI status (docs):
|
d2dced7
to
d2d92a7
Compare
!bench |
Here are the benchmark results for commit d2d92a7. Benchmark Metric Change
======================================================================
+ import Lean branches -3.7% (-145.9 σ)
+ import Lean instructions -4.1% (-137.2 σ)
- import Lean maxrss 3.4% (127.2 σ)
+ lake build clean instructions -1.7% (-34.7 σ)
- lake build no-op maxrss 2.7% (162.4 σ)
+ lake config elab instructions -1.2% (-56.9 σ)
- lake config elab maxrss 3.7% (158.6 σ)
+ lake config import instructions -3.1% (-62.0 σ)
- lake config import maxrss 4.0% (246.6 σ)
+ lake config tree instructions -2.9% (-68.3 σ)
- lake config tree maxrss 4.0% (218.8 σ)
+ lake env instructions -3.0% (-67.0 σ)
- lake env maxrss 4.0% (233.9 σ)
- language server startup maxrss 5.4% (359.5 σ)
- libleanshared.so binary size 1.2%
- reduceMatch maxrss 3.0% (516.7 σ)
- stdlib instructions 1.5% (672.0 σ)
- stdlib maxrss 3.2% (156.4 σ)
+ stdlib process pre-definitions -1.3% (-17.1 σ)
+ stdlib type checking -2.0% (-18.3 σ)
- stdlib wall-clock 15.9% (33.6 σ)
- stdlib size bytes .olean 1.9%
- stdlib size lines C 1.9%
+ stdlib size max dynamic symbols -1.1%
- tests/bench/ interpreted maxrss 2.9% (449.2 σ)
- tests/compiler sum binary sizes 1.0%
- workspaceSymbols maxrss 3.2% (388.5 σ) |
78f6d2a
to
d55c416
Compare
!bench |
Here are the benchmark results for commit d55c416. Benchmark Metric Change
==================================================================
+ import Lean branches -3.7% (-63.1 σ)
+ import Lean instructions -4.2% (-73.5 σ)
- import Lean maxrss 3.4% (342.4 σ)
+ lake build clean instructions -1.8% (-23.0 σ)
- lake build no-op maxrss 2.8% (117.9 σ)
+ lake config elab instructions -1.2% (-66.6 σ)
- lake config elab maxrss 3.8% (180.4 σ)
+ lake config import instructions -3.0% (-63.9 σ)
- lake config import maxrss 4.1% (268.8 σ)
+ lake config tree instructions -2.8% (-64.1 σ)
- lake config tree maxrss 4.1% (394.5 σ)
+ lake env instructions -2.9% (-57.2 σ)
- lake env maxrss 4.1% (210.4 σ)
- language server startup maxrss 5.6% (319.3 σ)
- libleanshared.so binary size 1.2%
- reduceMatch maxrss 3.0% (430.6 σ)
- stdlib instructions 1.5% (2116.5 σ)
- stdlib maxrss 3.2% (1230.5 σ)
- stdlib task-clock 1.1% (10.2 σ)
+ stdlib type checking -2.2% (-11.4 σ)
- stdlib wall-clock 14.9% (71.8 σ)
- stdlib size bytes .olean 1.9%
- stdlib size lines C 1.9%
+ stdlib size max dynamic symbols -1.1%
- tests/bench/ interpreted maxrss 2.8% (436.4 σ)
- tests/compiler sum binary sizes 1.0%
- workspaceSymbols maxrss 3.2% (457.5 σ) |
d55c416
to
d1caec0
Compare
!bench |
Here are the benchmark results for commit d1caec0. Benchmark Metric Change
==================================================================
+ import Lean branches -4.5% (-153.6 σ)
+ import Lean instructions -4.9% (-151.2 σ)
- import Lean maxrss 2.1% (52.9 σ)
+ lake build clean instructions -1.7% (-13.4 σ)
- lake build no-op maxrss 1.2% (47.0 σ)
+ lake config elab instructions -1.6% (-110.2 σ)
- lake config elab maxrss 1.6% (81.2 σ)
+ lake config import instructions -4.2% (-114.4 σ)
- lake config import maxrss 1.7% (101.3 σ)
+ lake config tree instructions -4.1% (-123.5 σ)
- lake config tree maxrss 1.7% (93.9 σ)
+ lake env instructions -4.2% (-103.3 σ)
- lake env maxrss 1.7% (59.8 σ)
- language server startup maxrss 2.1% (135.3 σ)
- libleanshared.so binary size 1.2%
- reduceMatch maxrss 1.8% (248.0 σ)
- stdlib instructions 1.3% (323.1 σ)
- stdlib maxrss 2.0% (3885.6 σ)
- stdlib tactic execution 1.5% (48.6 σ)
- stdlib wall-clock 4.6% (20.5 σ)
- stdlib size bytes .olean 1.9%
- stdlib size lines C 1.9%
+ stdlib size max dynamic symbols -1.1%
- tests/bench/ interpreted maxrss 1.8% (161.1 σ)
- tests/compiler sum binary sizes 1.0%
- workspaceSymbols maxrss 2.0% (265.9 σ) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
#4917 will expose users of the `Lean` API to the renaming of the hash map query methods. This PR aims to make the transition easier by adding deprecated functions with the old names.
d1caec0
to
fb3090e
Compare
fb3090e
to
5e052c0
Compare
5e052c0
to
56bf907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changes-stage0
Contains stage0 changes, merge manually using rebase
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes every use except for
ShareCommon
which I will do as a follow-up.This is very likely to break some users of the
Lean
API downstream.