Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lemmas about List.join #5130

Merged
merged 2 commits into from
Aug 22, 2024
Merged

feat: lemmas about List.join #5130

merged 2 commits into from
Aug 22, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Aug 22, 2024

No description provided.

@kim-em kim-em requested a review from digama0 as a code owner August 22, 2024 10:27
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 22, 2024 10:46 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 22, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 22, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 22, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em kim-em added this pull request to the merge queue Aug 22, 2024
theorem join_eq_append (xs : List (List α)) (ys zs : List α) :
xs.join = ys ++ zs ↔
(∃ as bs, xs = as ++ bs ∧ ys = as.join ∧ zs = bs.join) ∨
∃ as bs c cs ds, xs = as ++ (bs ++ c :: cs) :: ds ∧ ys = as.join ++ bs ∧
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could strengthen this by stating that bs is not empty, as else we are in the first case, right?

And maybe more natural to only have a nonempty cs rather than introducing c::cs?

Or if you like this style, use b::bs for the first list?

Merged via the queue into master with commit e9025bd Aug 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants