Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: restore reduceCtorEq in norm_cast tactic #5187

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat: restore reduceCtorEq in norm_cast tactic #5187

merged 1 commit into from
Aug 28, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Aug 28, 2024

#5167 removed reduceCtorEq from the default simproc set. norm_cast relies on it, so we add it back in there.

@kim-em kim-em requested a review from digama0 as a code owner August 28, 2024 01:44
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 28, 2024 01:52 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 28, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 44366382d3fdafb4e4f3de86d746624f0590c4a8 --onto 9305049f1ef7309842806c2a994a2020bb32a71f. (2024-08-28 02:00:58)

@kim-em kim-em added this pull request to the merge queue Aug 28, 2024
Merged via the queue into master with commit 0dc317c Aug 28, 2024
14 checks passed
@kim-em kim-em deleted the reduceCtorEq_in_norm_cast branch August 28, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-mathlib4-bot