Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: maximize term sharing at instantiateMVarDeclMVars #5226

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

leodemoura
Copy link
Member

The instantiateMVarDeclMVars is used by runTactic.

This commit address a performance issue at LinearCategory.

The `instantiateMVarDeclMVars` is used by `runTactic`.
@leodemoura
Copy link
Member Author

!bench

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 1, 2024 22:46 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 1, 2024
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 62af45b.
There were significant changes against commit 1b40ec5:

  Benchmark     Metric                  Change
  ======================================================
+ import Lean   task-clock               -3.9% (-13.8 σ)
+ import Lean   wall-clock               -3.9% (-13.2 σ)
+ nat_repr      task-clock               -2.6% (-16.5 σ)
+ nat_repr      wall-clock               -2.5% (-20.0 σ)
- stdlib        attribute application     1.3%  (13.1 σ)

@leodemoura leodemoura added this pull request to the merge queue Sep 1, 2024
Merged via the queue into master with commit 5214154 Sep 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants