Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow addition of release-ci label via comment #5343

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

thorimur
Copy link
Contributor

@thorimur thorimur commented Sep 14, 2024

Updates the PR labeling workflow to allow an external contributor to add the release-ci label to their own PR via comment. This is allows users on Windows and Intel-based macs to generate toolchains for local testing. The pull request template is also updated to reflect this.


See Zulip discussion here.

@thorimur thorimur marked this pull request as ready for review September 14, 2024 06:04
@thorimur thorimur requested review from Kha and kim-em as code owners September 14, 2024 06:04
@thorimur
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Sep 14, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f989520d2b17ec2fe987a69fee44a5272be1ff10 --onto 2080fc022187595020d519c1e08aa72340c4b5ff. (2024-09-14 06:20:01)

@kim-em kim-em removed the awaiting-review Waiting for someone to review the PR label Sep 14, 2024
@kim-em kim-em added this pull request to the merge queue Sep 14, 2024
Merged via the queue into leanprover:master with commit 60bb451 Sep 14, 2024
24 checks passed
tobiasgrosser pushed a commit to opencompl/lean4 that referenced this pull request Sep 16, 2024
Updates the PR labeling workflow to allow an external contributor to add
the `release-ci` label to their own PR via comment. This is allows users
on Windows and Intel-based macs to generate toolchains for local
testing. The pull request template is also updated to reflect this.

-----

See Zulip discussion
[here](https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/No.20binary.20for.20lean.20PR.20testing.20locally).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants