Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the last use of Lean.(HashSet|HashMap) #5362

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

hargoniX
Copy link
Contributor

No description provided.

@hargoniX
Copy link
Contributor Author

!bench

@hargoniX hargoniX force-pushed the hbv/kill-lean-hashset branch from a3fb005 to 6470afe Compare September 16, 2024 09:16
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 16, 2024 09:28 Inactive
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit a3fb005.
There were significant changes against commit 5eea835:

  Benchmark            Metric                 Change
  =============================================================
+ import Lean          task-clock              -8.2%  (-22.8 σ)
+ import Lean          wall-clock              -8.2%  (-23.7 σ)
- lake build no-op     maxrss                   1.6%  (121.3 σ)
- lake config elab     maxrss                   2.2% (1893.3 σ)
- lake config import   instructions             1.2%   (70.6 σ)
- lake config import   maxrss                   2.3%  (233.5 σ)
- lake config tree     instructions             1.2%   (17.5 σ)
- lake config tree     maxrss                   2.3%  (233.3 σ)
- lake env             instructions             1.3%   (27.3 σ)
- lake env             maxrss                   2.4%  (224.9 σ)
- stdlib               instantiate metavars    17.9%   (14.1 σ)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 16, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em
Copy link
Collaborator

kim-em commented Sep 18, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 6470afe.
There were significant changes against commit 5eea835:

  Benchmark            Metric         Change
  ====================================================
+ binarytrees.st       task-clock      -3.6% (-20.8 σ)
+ binarytrees.st       wall-clock      -3.6% (-20.7 σ)
- lake build no-op     maxrss           1.6% (251.2 σ)
- lake config elab     maxrss           2.2% (403.5 σ)
- lake config import   instructions     1.2%  (13.8 σ)
- lake config import   maxrss           2.4% (424.6 σ)
+ lake config import   task-clock      -9.1% (-12.2 σ)
+ lake config import   wall-clock      -9.1% (-12.1 σ)
- lake config tree     instructions     1.2%  (30.2 σ)
- lake config tree     maxrss           2.3% (119.1 σ)
- lake env             instructions     1.3%  (39.4 σ)
- lake env             maxrss           2.4% (288.1 σ)
+ unionfind            task-clock     -18.3% (-20.0 σ)
+ unionfind            wall-clock     -18.3% (-19.9 σ)

@hargoniX
Copy link
Contributor Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 6470afe.
There were significant changes against commit 5eea835:

  Benchmark            Metric         Change
  ====================================================
+ binarytrees.st       task-clock      -3.6% (-20.8 σ)
+ binarytrees.st       wall-clock      -3.6% (-20.7 σ)
- lake build no-op     maxrss           1.6% (251.2 σ)
- lake config elab     maxrss           2.2% (403.5 σ)
- lake config import   instructions     1.2%  (13.8 σ)
- lake config import   maxrss           2.4% (424.6 σ)
+ lake config import   task-clock      -9.1% (-12.2 σ)
+ lake config import   wall-clock      -9.1% (-12.1 σ)
- lake config tree     instructions     1.2%  (30.2 σ)
- lake config tree     maxrss           2.3% (119.1 σ)
- lake env             instructions     1.3%  (39.4 σ)
- lake env             maxrss           2.4% (288.1 σ)
+ unionfind            task-clock     -18.3% (-20.0 σ)
+ unionfind            wall-clock     -18.3% (-19.9 σ)

@hargoniX
Copy link
Contributor Author

Talked with Mac, he thinks these perf diffs are acceptable.

@hargoniX hargoniX added this pull request to the merge queue Sep 18, 2024
Merged via the queue into master with commit fa6afa8 Sep 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants