Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lake: selective build cache fetch & display #5572

Merged
merged 2 commits into from
Oct 1, 2024
Merged

feat: lake: selective build cache fetch & display #5572

merged 2 commits into from
Oct 1, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Oct 1, 2024 •
edited
Loading

Lake no longer attempts to fetch Reservoir build caches (barrels) for non-Reservoir dependencies, and it will only fetch them for Reservoir dependencies in the presence of a known toolchain.

Also, optional build job failures are now only displayed in verbose mode.

@tydeu tydeu force-pushed the lake/selective-build-fetch branch from 17dc879 to 74697ef Compare October 1, 2024 16:23
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 1, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-10-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-10-01 16:45:37)

@tydeu tydeu added the release-ci Enable all CI checks for a PR, like is done for releases label Oct 1, 2024
@tydeu tydeu marked this pull request as draft October 1, 2024 16:53
@tydeu tydeu marked this pull request as ready for review October 1, 2024 18:55
@tydeu tydeu force-pushed the lake/selective-build-fetch branch from ebe1647 to 5229759 Compare October 1, 2024 20:22
@tydeu tydeu enabled auto-merge October 1, 2024 20:22
@tydeu tydeu added this pull request to the merge queue Oct 1, 2024
Merged via the queue into leanprover:master with commit 5eb6c67 Oct 1, 2024
21 checks passed
@tydeu tydeu deleted the lake/selective-build-fetch branch October 1, 2024 21:46
kim-em added a commit that referenced this pull request Oct 4, 2024
@kim-em
Revert "feat: lake: selective build cache fetch & display (#5572)"
f87859f 
This reverts commit 5eb6c67.
kim-em added a commit that referenced this pull request Oct 4, 2024
@kim-em
Reapply "feat: lake: selective build cache fetch & display (#5572)"
385abfb 
This reverts commit f87859f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tydeu @leanprover-community-bot