Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding Insert/Singleton/Union instances for HashMap/Set.Raw #5590

Merged
merged 7 commits into from
Oct 3, 2024
Merged

feat: adding Insert/Singleton/Union instances for HashMap/Set.Raw #5590

merged 7 commits into from
Oct 3, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Oct 2, 2024 •
edited
Loading

These were missing from #5581.

@kim-em kim-em requested a review from TwoFX as a code owner October 2, 2024 05:44
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 2, 2024 06:00 Inactive
@kim-em kim-em mentioned this pull request Oct 2, 2024
Closed
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 2, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 2, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1329a264c814efdbe81747f0d44b9b355a198262 --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-02 06:08:29)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 6a59a3a3733f359ca1aa90d0d3e81c6c0a44b469 --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-02 06:24:55)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 2, 2024 06:15 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 2, 2024 06:22 Inactive
@kim-em kim-em enabled auto-merge October 2, 2024 07:23
TwoFX
TwoFX reviewed Oct 2, 2024
View reviewed changes
src/Lean/Elab/Tactic/LibrarySearch.lean Outdated
Comment on lines 27 to 28
let (_, goal) ← mvar.intros
mvar.withContext do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it was supposed to be part of a different PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, sorry. I've missed the boat for v4.13.0-rc1 in any case, I'll deal with this in less of a hurry tomorrow.

@TwoFX TwoFX disabled auto-merge October 2, 2024 07:35
@kim-em kim-em enabled auto-merge October 3, 2024 06:06
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 3, 2024 06:25 Inactive
@kim-em kim-em added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit b7d6a4b Oct 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX left review comments

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-bot @TwoFX