feat: add BitVec.[toNat|toInt|toFin|getLsbD|getMsbD|getElem|msb]_fill #6177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog-library |
tobiasgrosser
force-pushed
the
bv_fill
branch
from
c23c0c8 to
c5cc20c
Compare
This PR implements BitVec.[*]_fill.
tobiasgrosser
force-pushed
the
bv_fill
branch
from
c5cc20c to
b6a7862
Compare
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
kim-em
reviewed
Nov 23, 2024
|
An alternative approch here might be to deprecate/delete |
It was added in 75272cb without further comments. Given that its a convenient helper and its easy to complete the API, I would be happy to keep it. |
|
awaiting-review |
github-actions
bot
added
awaiting-review
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Jan 21, 2025
…leanprover#6177) This PR implements `BitVec.*_fill`. We also add `toInt_allOnes` and `toFin_allOnes` as the former is needed here. This completes the allOnes API.
JovanGerb
pushed a commit
to JovanGerb/lean4
that referenced
this pull request
Jan 21, 2025
…leanprover#6177) This PR implements `BitVec.*_fill`. We also add `toInt_allOnes` and `toFin_allOnes` as the former is needed here. This completes the allOnes API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
BitVec.*_fill.We also add
toInt_allOnesandtoFin_allOnesas the former is needed here. This completes the allOnes API.