-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bitvec.{msb, toInt, toFin}_{sdiv, udiv}
lemmas
#6360
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitvec.{msb, toInt}_{sdiv, udiv}
lemmasBitvec.{msb, toInt, toFin}_{sdiv, udiv}
lemmas
This PR has been superseded by #6402, the sdiv stuff is still WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
toInt
andmsb
lemmas for (un)signed bitvector division.Todo:
msb_udiv
msb_sdiv
toInt_sdiv
We don't have a
toInt_udiv
lemma, since the only truly general statement we can make does no better than unfolding the definition, and it's not uncontroversially clear how to unfoldtoInt
(seetoInt_eq_msb_cond
/toInt_eq_toNat_cond
/toInt_eq_toNat_bmod
for a few options). Instead, we do havetoInt_udiv_of_msb
that's able to a more meaningful rewrite given an extra side-condition (thatx.msb = false
)Similarly, we do have
toFin_udiv
, but we don't addtoFin_sdiv
; the latter can do no better than unfolding the definition, which is an unwieldy match statement.