Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: negative timestamps and PlainDateTimes before 1970 #6668

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: negative timestamps and PlainDateTimes before 1970 #6668

merged 1 commit into from
Jan 20, 2025

Conversation

algebraic-dev
Copy link
Contributor

This PR fixes negative timestamps and PlainDateTimes before 1970.

@algebraic-dev algebraic-dev self-assigned this Jan 16, 2025
@algebraic-dev algebraic-dev requested a review from TwoFX as a code owner January 16, 2025 15:42
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 16, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b3f8feffd3b3d6bd2ff79d7b2949b51fe5663714 --onto a955708b6c5f25e7f9c9ae7b951f8f3d5aefe377. (2025-01-16 16:10:05)

@TwoFX TwoFX added this pull request to the merge queue Jan 20, 2025
Merged via the queue into leanprover:master with commit 1d03cd6 Jan 20, 2025
17 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Jan 21, 2025
@algebraic-dev @luisacicolini
fix: negative timestamps and PlainDateTimes before 1970 (leanprover…
447ad1a 
…#6668)

This PR fixes negative timestamps and `PlainDateTime`s before 1970.
@adpaco-aws adpaco-aws mentioned this pull request Feb 4, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX Awaiting requested review from TwoFX TwoFX is a code owner

Assignees

@algebraic-dev algebraic-dev

Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algebraic-dev @leanprover-community-bot @TwoFX