refactor: lake: all targets produce jobs #6780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 26, 2025
tydeu
force-pushed
the
lake/targets-are-jobs
branch
from
516e2b5 to
e23ac7e
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 26, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 26, 2025
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
tydeu
force-pushed
the
lake/targets-are-jobs
branch
from
e23ac7e to
d5f0ce7
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 26, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 26, 2025
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 24, 2025
This PR makes all targets and all `fetch` calls produce a `Job` of some value. As part of this change, facet definitions (e.g., `library_data`, `module_data`, `package_data`) and Lake type families (e.g., `FamilyOut`) should no longer include `Job` in their types (as this is now implicit).
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
This PR makes all targets and all `fetch` calls produce a `Job` of some value. As part of this change, facet definitions (e.g., `library_data`, `module_data`, `package_data`) and Lake type families (e.g., `FamilyOut`) should no longer include `Job` in their types (as this is now implicit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all targets and all
fetchcalls produce aJobof some value. As part of this change, facet definitions (e.g.,library_data,module_data,package_data) and Lake type families (e.g.,FamilyOut) should no longer includeJobin their types (as this is now implicit).