feat: align take/drop/extract across List/Array/Vector
#6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
requested review from
digama0,
kmill,
leodemoura and
tydeu
as code owners
|
!bench |
|
Here are the benchmark results for commit ae4a090. Benchmark Metric Change
=============================================================
+ bv_decide_inequality.lean branch-misses -1.2% (-10.3 σ)
+ bv_decide_mul branch-misses -2.7% (-23.2 σ)
+ rbmap_1 task-clock -5.0% (-19.6 σ)
+ rbmap_1 wall-clock -4.9% (-19.8 σ)
+ rbmap_fbip task-clock -7.1% (-117.0 σ)
+ rbmap_fbip wall-clock -7.1% (-115.2 σ)
+ stdlib task-clock -1.5% (-251.0 σ) |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 24, 2025
…r#6860) This PR makes `take`/`drop`/`extract` available for each of `List`/`Array`/`Vector`. The simp normal forms differ, however: in `List`, we simplify `extract` to `take+drop`, while in `Array` and `Vector` we simplify `take` and `drop` to `extract`. We also provide `Array/Vector.shrink`, which simplifies to `take`, but is implemented by repeatedly popping. Verification lemmas for `Array/Vector.extract` to follow in a subsequent PR.
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
…r#6860) This PR makes `take`/`drop`/`extract` available for each of `List`/`Array`/`Vector`. The simp normal forms differ, however: in `List`, we simplify `extract` to `take+drop`, while in `Array` and `Vector` we simplify `take` and `drop` to `extract`. We also provide `Array/Vector.shrink`, which simplifies to `take`, but is implemented by repeatedly popping. Verification lemmas for `Array/Vector.extract` to follow in a subsequent PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
take/drop/extractavailable for each ofList/Array/Vector. The simp normal forms differ, however: inList, we simplifyextracttotake+drop, while inArrayandVectorwe simplifytakeanddroptoextract. We also provideArray/Vector.shrink, which simplifies totake, but is implemented by repeatedly popping. Verification lemmas forArray/Vector.extractto follow in a subsequent PR.