-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace bad simp lemmas for Id
#7352
Draft
eric-wieser
wants to merge
2
commits into
leanprover:master
Choose a base branch
from
eric-wieser:patch-43
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog-library |
I've split some helper lemmas to #7356, which are independent of this fix |
Mathlib CI status (docs):
|
729e005
to
439669c
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
This PR makes `simp` able to simplify basic `for` loops in monads other than `Id`. This is some prework for #7352, where the `Id` lemmas will be deprecated.
This is free at runtime, since both `Id.run` and `pure` are inlined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the
simp
set around theId
monad.In particular, it stops encoding the "defeq abuse" of
Id X = X
in the statements of theorems, instead usingId.run
andpure
to pass back and forth between these two spellings.This fixes the problem with the current simp set where
Id.run (pure x)
is simplified toId.run x
, instead of the desirablex
.This is particularly bad because the
x
is sometimes inferred with typeId X
instead ofX
, which prevents othersimp
lemmas aboutX
from firing.Making
Id
reducible instead is not an option, as then theMonad
instances would have nothing to key on.