Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: find realizations from other env branches #7385

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

Kha
Copy link
Member

@Kha Kha commented Mar 7, 2025

No description provided.

@Kha Kha added the changelog-no Do not include this PR in the release changelog label Mar 7, 2025
@Kha Kha force-pushed the push-kvxmultyuwxu branch from 215648c to c85e5bd Compare March 7, 2025 20:41
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 7, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Mar 7, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a8a5c6cff1208d80517c05a1d4ac38dcadfb4030 --onto ca0d8226192e7c0cdcc71d6322c3226ad4f73f30. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-07 21:10:03)
    Forcing Mathlib CI because the force-mathlib-ci label is present, despite problem: - ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-03-08 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2025-03-08 11:26:12)
  • ✅ Mathlib branch lean-pr-testing-7385 has successfully built against this PR. (2025-03-08 12:14:47) View Log
  • ✅ Mathlib branch lean-pr-testing-7385 has successfully built against this PR. (2025-03-08 17:54:33) View Log
  • 💥 Mathlib branch lean-pr-testing-7385 build failed against this PR. (2025-03-08 19:42:55) View Log
  • ✅ Mathlib branch lean-pr-testing-7385 has successfully built against this PR. (2025-03-10 09:35:54) View Log
  • ✅ Mathlib branch lean-pr-testing-7385 has successfully built against this PR. (2025-03-10 11:48:29) View Log
    Forcing Mathlib CI because the force-mathlib-ci label is present, despite problem: - ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 22b6b49a432bdfdb8a916f3f9b41a2e7b61594c1 --onto 7bfa8f6296ebfebc497d5b30d34f494bcc9782a2. (2025-03-10 16:17:23)
  • ✅ Mathlib branch lean-pr-testing-7385 has successfully built against this PR. (2025-03-10 17:05:35) View Log

@Kha Kha force-pushed the push-kvxmultyuwxu branch from c85e5bd to 4da709f Compare March 8, 2025 10:58
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 8, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 8, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 8, 2025
@Kha
Copy link
Member Author

Kha commented Mar 8, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 4da709f.
There were significant changes against commit 565c6f3:

  Benchmark                      Metric               Change
  =====================================================================
- Init.Data.List.Sublist async   branches               1.1%   (96.7 σ)
- Init.Prelude async             branches              10.9% (1757.0 σ)
- Init.Prelude async             instructions           8.8% (1295.7 σ)
+ Init.Prelude async             maxrss                -4.3%  (-35.7 σ)
- identifier auto-completion     branches               5.9%  (783.4 σ)
- identifier auto-completion     instructions           5.1%  (602.6 σ)
- stdlib                         blocked              161.9%  (588.7 σ)
- stdlib                         dsimp                  5.5%  (108.7 σ)
+ stdlib                         share common exprs    -4.8%  (-12.5 σ)
+ stdlib                         type checking         -2.2%  (-19.5 σ)
- stdlib                         wall-clock             9.4%   (13.9 σ)

@Kha Kha force-pushed the push-kvxmultyuwxu branch from 4da709f to 43f0b0b Compare March 8, 2025 16:46
@Kha
Copy link
Member Author

Kha commented Mar 8, 2025

!bench

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 8, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 8, 2025
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 43f0b0b.
There were significant changes against commit 565c6f3:

  Benchmark                      Metric                  Change
  ========================================================================
+ Init.Data.List.Sublist async   branches                 -2.1% (-202.2 σ)
+ Init.Data.List.Sublist async   instructions             -1.7% (-153.8 σ)
- Init.Data.List.Sublist async   wall-clock               12.7%   (11.5 σ)
- Init.Prelude async             wall-clock               15.1%   (21.1 σ)
+ reduceMatch                    instructions             -1.3%  (-52.5 σ)
- stdlib                         attribute application    12.4%   (19.3 σ)
- stdlib                         blocked                 152.4%   (87.7 σ)
+ stdlib                         dsimp                    -4.0%  (-14.4 σ)
- stdlib                         instantiate metavars      5.1%   (15.5 σ)
+ stdlib                         share common exprs       -2.9%  (-10.6 σ)
+ stdlib                         tactic execution         -3.4%  (-22.6 σ)
+ stdlib                         task-clock               -2.5%  (-12.3 σ)
+ stdlib                         type checking            -2.4%  (-17.3 σ)
- stdlib                         wall-clock               10.7%   (23.4 σ)

@Kha Kha force-pushed the push-kvxmultyuwxu branch from 43f0b0b to 097a8f0 Compare March 8, 2025 19:02
@Kha
Copy link
Member Author

Kha commented Mar 8, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 097a8f0.
The entire run failed.
Found no significant differences.

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 8, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 8, 2025
@leanprover-community-bot leanprover-community-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan and removed builds-mathlib CI has verified that Mathlib builds against this PR labels Mar 8, 2025
@Kha Kha force-pushed the push-kvxmultyuwxu branch from 097a8f0 to 1fddb60 Compare March 10, 2025 08:19
@Kha
Copy link
Member Author

Kha commented Mar 10, 2025

!bench

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 10, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 10, 2025
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 1fddb60.
There were significant changes against commit 565c6f3:

  Benchmark                      Metric               Change
  ======================================================================
+ Init.Data.List.Sublist async   branches              -2.3%  (-362.4 σ)
+ Init.Data.List.Sublist async   instructions          -1.9%  (-291.8 σ)
+ Init.Prelude async             branches              -7.2%  (-226.2 σ)
+ Init.Prelude async             instructions          -5.8%  (-157.2 σ)
+ identifier auto-completion     branches             -16.0% (-1050.4 σ)
+ identifier auto-completion     instructions         -13.5%  (-799.2 σ)
+ identifier auto-completion     task-clock           -11.5%   (-10.3 σ)
+ reduceMatch                    instructions          -1.4%   (-57.4 σ)
+ stdlib                         dsimp                 -7.2%   (-50.5 σ)
+ stdlib                         instructions          -1.5%  (-297.9 σ)
+ stdlib                         share common exprs    -3.6%   (-20.2 σ)

@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Mar 10, 2025
@Kha Kha force-pushed the push-kvxmultyuwxu branch from 1fddb60 to f3b921d Compare March 10, 2025 10:33
@Kha Kha added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Mar 10, 2025
@Kha Kha marked this pull request as ready for review March 10, 2025 10:33
@Kha Kha requested a review from digama0 as a code owner March 10, 2025 10:33
@Kha Kha enabled auto-merge March 10, 2025 10:34
@Kha
Copy link
Member Author

Kha commented Mar 10, 2025

!bench

@Kha Kha disabled auto-merge March 10, 2025 10:34
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 10, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 10, 2025
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit f3b921d.
There were significant changes against commit 565c6f3:

  Benchmark                      Metric         Change
  ===============================================================
+ Init.Data.List.Sublist async   branches        -2.3% (-125.7 σ)
+ Init.Data.List.Sublist async   instructions    -1.9%  (-91.2 σ)
+ Init.Prelude async             branches        -7.3% (-229.6 σ)
+ Init.Prelude async             instructions    -5.9% (-156.4 σ)
+ identifier auto-completion     branches       -16.2% (-872.1 σ)
+ identifier auto-completion     instructions   -13.6% (-714.1 σ)
+ reduceMatch                    instructions    -1.4%  (-39.4 σ)
+ stdlib                         instructions    -1.5% (-142.5 σ)
+ stdlib                         task-clock      -1.2%  (-25.2 σ)

@leanprover-community-bot leanprover-community-bot removed the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Mar 10, 2025
@Kha Kha added this pull request to the merge queue Mar 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2025
@Kha Kha force-pushed the push-kvxmultyuwxu branch from f3b921d to 6076f9b Compare March 10, 2025 15:38
@Kha Kha enabled auto-merge March 10, 2025 15:39
@Kha Kha added this pull request to the merge queue Mar 10, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 10, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 10, 2025
auto-merge was automatically disabled March 10, 2025 16:21

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2025
@Kha Kha added this pull request to the merge queue Mar 10, 2025
Merged via the queue into leanprover:master with commit 9d39942 Mar 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-no Do not include this PR in the release changelog force-mathlib-ci toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants