Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lake: config field autocomplete in whitespace #7393

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Mar 8, 2025

This PR adds autocompletion support for Lake configuration fields in the Lean DSL at the indented whitespace after an existing field. Autocompletion in the absence of any fields is currently still not supported.

Breaking change: The nonstandard braced configuration syntax now uses a semicolon ; rather than a comma , as a separator. Indentation can still be used as an alternative to the separator.

@tydeu tydeu added the changelog-lake Lake label Mar 8, 2025
@tydeu tydeu changed the title feat; lake: config field autocomplete in whitespace feat: lake: config field autocomplete in whitespace Mar 8, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 8, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 8, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 8, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 8, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@tydeu tydeu marked this pull request as ready for review March 10, 2025 03:58
@tydeu tydeu added this pull request to the merge queue Mar 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2025
@tydeu tydeu added this pull request to the merge queue Mar 10, 2025
Merged via the queue into leanprover:master with commit 77609dc Mar 10, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants