Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the Subsingleton instance for Squash work for an arbitrary Sort #7406

Merged
merged 2 commits into from
Mar 11, 2025
Merged

fix: make the Subsingleton instance for Squash work for an arbitrary Sort #7406

merged 2 commits into from
Mar 11, 2025

Conversation

cppio
Copy link
Contributor

@cppio cppio commented Mar 9, 2025

This PR makes the instance for Subsingleton (Squash α) work for α : Sort u.

Closes #7405

The fix removes some unused section/variable commands. They were mistakenly kept when EqvGen was removed in 1d338c4.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 9, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 9, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#7406
f2b71dd
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 9, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#7406
b3368d5
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 9, 2025
@cppio
Copy link
Contributor Author

cppio commented Mar 9, 2025

changelog-library

@github-actions github-actions bot added the changelog-library Library label Mar 9, 2025
@hargoniX
Copy link
Contributor

Could you put the test in tests/lean/run with no output file? We usually only commit to tests/lean if a nonempty output file is required.

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 10, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#7406
dde5509
@nomeata nomeata added this pull request to the merge queue Mar 11, 2025
Merged via the queue into leanprover:master with commit 7c0b72e Mar 11, 2025
15 checks passed
@cppio cppio deleted the squash-fix branch March 11, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subsingleton instance for Squash α does not work for α : Sort u
5 participants
@cppio @leanprover-community-bot @hargoniX @eric-wieser @nomeata